[Merge] lp:~phablet-team/network-manager/lp1361864 into lp:~phablet-team/network-manager/vivid-phone-overlay

[Tony Espy]

Tony Espy has proposed merging lp:~phablet-team/network-manager/lp1361864 into lp:~phablet-team/network-manager/vivid-phone-overlay.

Requested reviews:
  Alfonso Sanchez-Beato (alfonsosanchezbeato)
Related bugs:
  Bug #1361864 in ofono (Ubuntu): "add "Preferred" property to ConnectionContext interface"
  https://bugs.launchpad.net/ubuntu/+source/ofono/+bug/1361864

For more details, see:
https://code.launchpad.net/~phablet-team/network-manager/lp1361864/+merge/263855

This change adds support for the new ofono gprs-context property 'Preferred'.  

When a context is set to 'Preferred=true', NM should disregard all other contexts for the the same IMSI.   If the a context is connected, and another context is set as 'Preferred', NM will disconnect the existing context, and attempt to activate the 'Preferred' context.  If the 'Preferred' context fails, NM will not try to activate any other contexts.

When a context is set to 'Preferred=false', NM will not deactivate the context, if currently connected.

This change also removes the code in NMMOdemOfono which invoked a DBus method (ReadImsiConetexts) provided by SCPlugin-Ofono, as this only had any effect when a new context was added. and this case is already handled by the imsi_monitor.

Finally, the code in NMDeviceModem which disabled and re-enabled autoconnect based upon device and modem_state was removed, as it caused a hang on arale when a deactivate context failed, and the retry limit was hit, which causes a modem reset.

-- 
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/network-manager/vivid-phone-overlay.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 21003 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20150706/abee0337/attachment-0001.diff>