[Merge] lp:~osomon/webbrowser-app/find-in-page into lp:webbrowser-app

[Riccardo Padovani]

Review: Needs Fixing

# Issue

If you click on a link while it's in search mode it doesn't exit the search mode but it insert the url in the address bar and then when you insert a new url it search it in the page.

When you open a new tab it should exit the search mode

In all the other browsers the search mode is sticked to the tab itself, so I can have it enabled on one tab and switch the tab and return to the same tab and having the same search inserted.
I appreciate this is difficult to implement, so could be done in a second branch, but I urge you to dismiss the search when you change the tab

# Nitpick

49	+    text: i18n.tr("Find in Page")
243	+                    text: i18n.tr("Find in page")

Be coherent :-)

# Opinions

80	+    // Only start searches when the user types two or more characters

Could I say I find it not well designed? If I insert one letter it gives 0/0 so I think there isn't any occurence of that letter in the page. All other browsers search also with only one char.

Also, I think we need an icon to put in the addressbar when it's in find-in-page mode



-- 
https://code.launchpad.net/~osomon/webbrowser-app/find-in-page/+merge/263547
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~osomon/webbrowser-app/find-in-page into lp:webbrowser-app.