[Merge] lp:~uriboni/webbrowser-app/find-in-page into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Wed Jul 1 15:48:49 UTC 2015


Review: Needs Fixing

There are now conflicts when merging this branch into the latest trunk.

Additionally the QML unit tests are failing with errors like this:

    AddressBar.qml:247: TypeError: Property 'next' of object QObject_QML_32(0x2e540a0) is not a function

And as pointed out by Riccardo, validating a URL in the address bar with Enter doesn’t work any longer, and Ctrl+F should activate the find in page mode.
-- 
https://code.launchpad.net/~uriboni/webbrowser-app/find-in-page/+merge/258225
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list