[Merge] lp:~abreu-alexandre/webbrowser-app/intent into lp:webbrowser-app

Alexandre Abreu alexandre.abreu at canonical.com
Fri Jan 30 16:18:22 UTC 2015


> > > In IntentFilter::isValidIntentFilterResult(…), the checks expect the
> result
> > to
> > > have a host, but in the declaration of the IntentUriDescription struct,
> > 'host'
> > > is marked optional. So, is it optional or required?
> >
> > optional as you known and as I know ..., but as I said before
> > I wanted the object sent to the js have a strict & fixed structure,
> >
> > I can remove if you strongly object,
> 
> I won’t strongly object :)
> I’m just concerned that if someone has to pick up that code in the future, she
> will be puzzled as to whether host is optional or required.
> 
> By the way, could you add a link to
> https://developer.chrome.com/multidevice/android/intents somewhere in the
> code, for reference?

+1
-- 
https://code.launchpad.net/~abreu-alexandre/webbrowser-app/intent/+merge/247421
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list