[Merge] lp:~abreu-alexandre/webbrowser-app/intent into lp:webbrowser-app

Alexandre Abreu alexandre.abreu at canonical.com
Fri Jan 30 16:11:55 UTC 2015


> > > In tests/unittests/intent-filter/tst_IntentFilterTests.cpp:
> > >
> > > 1004    +        IntentFilter * pf = new IntentFilter(QString());
> > > 1050    +        IntentFilter * pf = new
> IntentFilter(filterFunctionSource);
> > >
> > > pf is leaked. Could it be instantiated on the stack instead?
> >

ok, I had a compiler error that led me to quickly think that the qobject
based was not statically instantiatable,

+1
-- 
https://code.launchpad.net/~abreu-alexandre/webbrowser-app/intent/+merge/247421
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list