[Merge] lp:~xnox/ubuntu-release-upgrader/lp1409555 into lp:ubuntu-release-upgrader

Michael Vogt michael.vogt at canonical.com
Thu Jan 29 14:05:28 UTC 2015


Review: Approve

Hi Dimitri, thanks a lot for this work. The branch looks good, whats puzzling is that I see a test failure when running bzr-buildpackage. It looks like nosetests3 is not using the current directory and not honoring PYTHONPATH here which is a bit confusing. Only when python3-distupgrade is not instaleld do the tests work for me when run with nosetest3. Beside this the diff looks fine and I think we should upload it.
-- 
https://code.launchpad.net/~xnox/ubuntu-release-upgrader/lp1409555/+merge/246233
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~xnox/ubuntu-release-upgrader/lp1409555 into lp:ubuntu-release-upgrader.



More information about the Ubuntu-reviews mailing list