[Merge] lp:~abreu-alexandre/webbrowser-app/intent into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Wed Jan 28 16:38:04 UTC 2015


Review: Needs Fixing

In tests/unittests/intent-filter/CMakeLists.txt:

838	+set(TEST tst_IntentFilterTests)
839	+set(SOURCES
840	+    ${CMAKE_SOURCE_DIR}/src/app/webcontainer/intent-filter.cpp

  this should be ${webapp-container_SOURCE_DIR}/intent-filter.cpp

841	+    tst_IntentFilterTests.cpp
842	+)
843	+set(WEBAPP_CONTAINER_INTENT_FILTER webapp-container-intent-filter)

  the variable defined here seems unused

844	+include_directories(${CMAKE_SOURCE_DIR})

  this should be ${webapp-container_SOURCE_DIR}

845	+add_executable(${TEST} ${SOURCES})
846	+qt5_use_modules(${TEST} Core Test Qml)
847	+add_test(${TEST} ${CMAKE_CURRENT_BINARY_DIR}/${TEST} -xunitxml -o ${TEST}.xml)
-- 
https://code.launchpad.net/~abreu-alexandre/webbrowser-app/intent/+merge/247421
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list