[Merge] lp:~rpadovani/webbrowser-app/fixBookmarkDesign into lp:webbrowser-app

Riccardo Padovani riccardo at rpadovani.com
Mon Jan 26 12:15:17 UTC 2015


> After applying the change, this is how it looks on my desktop (utopic):
> http://people.canonical.com/~osomon/multi-select.png.
> 
> There are a few things that need adjusting still, wrt the visual spec:
>  - icons in the top toolbar are scaled up, they shouldn’t be

Sorry about this, I'm on vivid and it works well, I think it's due this commit[0] in the sdk, probably hasn't been backported yet. Anyway, I reworked the Icon, so now should be ok.

>  - icons in the top toolbar need to have a left and right margin to be aligned
> with the rest of the items on screen

Fixed

>  - the horizontal line that underlines each section header should be aligned
> to the left with the checkboxes, and to the right it should have a 2GU margin

fixed 

>  - the text of the section headers should also be aligned to the left with the
> checkboxes (i.e. a 2GU left margin)

fixed 

>  - there should be 2GUs between the horizontal line and the first item in a
> section (there currently is only one)

Fixed

>  - there should be 2.5GUs between the last item in a section and the text of
> the following header

About this, I didn't find any way to find if a section it's the first, so I set a negative margin to the listview to compensate the topmargin the first section has. There is a better way to implement that?

[0]https://bazaar.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/trunk/revision/1115
-- 
https://code.launchpad.net/~rpadovani/webbrowser-app/fixBookmarkDesign/+merge/247512
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list