[Merge] lp:~abreu-alexandre/webbrowser-app/intent into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Fri Jan 23 16:19:16 UTC 2015


OK, now that looks better (my comment went in just after your change).

I’m wondering, why does the function receive an object that has 'scheme', 'host' and 'uri' as keys?
Wouldn’t it be enough to pass the function a string (the full intent:// URI) and expect a string (the transformed http:// URI) in return?

Also, is it really useful to allow the custom intent file to have a different name than the default one? It seems it adds a lot of logic for no apparent gain.
-- 
https://code.launchpad.net/~abreu-alexandre/webbrowser-app/intent/+merge/247421
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~abreu-alexandre/webbrowser-app/intent into lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list