[Merge] lp:~tiagosh/messaging-app/fix-1376793 into lp:messaging-app
Gustavo Pichorim Boiko
gustavo.boiko at canonical.com
Fri Jan 23 12:32:23 UTC 2015
Review: Needs Fixing
331 + time.sleep(2)
332 + count = 0
333 + for thread in threads:
334 + if thread.height != 0:
335 + count+=1
336 +
337 + self.assertThat(count, Equals(3))
I think it would be better to write a function to count the threads and use:
self.assertThat(count_visible_threads(threads), Eventually(Equals(3))
so that we don't have to rely on timers.
--
https://code.launchpad.net/~tiagosh/messaging-app/fix-1376793/+merge/245812
Your team Ubuntu Phablet Team is subscribed to branch lp:messaging-app.
More information about the Ubuntu-reviews
mailing list