[Merge] lp:~kramsmada/ubuntu/vivid/gnupg2/1407513-gpg-agent-set-ssh-env-vars into lp:ubuntu/gnupg2

Mark Adams mark at markadams.me
Mon Jan 5 00:13:22 UTC 2015


Mark Adams has proposed merging lp:~kramsmada/ubuntu/vivid/gnupg2/1407513-gpg-agent-set-ssh-env-vars into lp:ubuntu/gnupg2.

Requested reviews:
  Marc Deslauriers (mdeslaur)
Related bugs:
  Bug #1407513 in gnupg2 (Ubuntu): "gpg-agent upstart script doesn't set SSH environment variables"
  https://bugs.launchpad.net/ubuntu/+source/gnupg2/+bug/1407513

For more details, see:
https://code.launchpad.net/~kramsmada/ubuntu/vivid/gnupg2/1407513-gpg-agent-set-ssh-env-vars/+merge/245538

This fixes a bug I reported (LP: #1407513) which describes an issue where the upstart gpg-agent script only sets the GPG_AGENT_INFO environment variable when, in fact, it should also set SSH_AGENT_PID and SSH_AUTH_SOCK if "enable-ssh-support" is set in the GPG agent configuration.

Essentially, this patch modifies the existing upstart script so that it checks to see if the "enable-ssh-support" config flag is set, and if so, it sets and unsets the associated SSH environment variables appropriately.

This fix mainly applies to users who store their SSH keys on a GPG smartcard and would like to easily make them available to SSH-based applications.
-- 
Your team Ubuntu branches is subscribed to branch lp:ubuntu/gnupg2.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1553 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20150105/56210df7/attachment.diff>


More information about the Ubuntu-reviews mailing list