[Merge] lp:~mvo/ubuntu/vivid/ubuntu-core-upgrader/add-test-tar-generator into lp:ubuntu/ubuntu-core-upgrader

Michael Vogt michael.vogt at canonical.com
Fri Feb 27 09:54:13 UTC 2015


The proposal to merge lp:~mvo/ubuntu/vivid/ubuntu-core-upgrader/add-test-tar-generator into lp:ubuntu/ubuntu-core-upgrader has been updated.

Description changed to:

This branch adds a minimal test for the tar_generator() method. With that
in place the other parts of the function (like removed_files handling etc)
can be tested.

I moved the function it out of "Upgrader" because upgrader takes the "options" argument and that caused me some headache to mock. But it does not have to be this way, if we create a MockOptions. But the advantage of having it as a independent function is that all state is explicitly passed in and we don't have to worry about internal object state.

For more details, see:
https://code.launchpad.net/~mvo/ubuntu/vivid/ubuntu-core-upgrader/add-test-tar-generator/+merge/251230
-- 
Your team Ubuntu branches is requested to review the proposed merge of lp:~mvo/ubuntu/vivid/ubuntu-core-upgrader/add-test-tar-generator into lp:ubuntu/ubuntu-core-upgrader.



More information about the Ubuntu-reviews mailing list