[Merge] lp:~rpadovani/webbrowser-app/searchenginesmodel into lp:webbrowser-app
Olivier Tilloy
olivier.tilloy at canonical.com
Thu Feb 26 12:28:48 UTC 2015
One more thing: when we migrate the settings storage to pure QML (using Qt.labs.Settings), we will need a way to retrieve the attributes of the current search engine in QML. I’m thinking of a QObject-derived class with a 'name' property that can be set, and readonly attributes for the icon, description, and URL template. This class would need to parse the relevant file under ~/.local/share/webbrowser-app/searchengines/, so it would share some code with the list model.
I think it makes sense to do this work in the same branch, as there will be common code and patterns.
We would end up with something like that (pseudo QML code):
Browser {
Settings {
id: settings
}
SearchEngine {
id: searchengine
name: settings.searchengine
}
AddressBar {
searchUrl: searchengine.urlTemplate
}
}
--
https://code.launchpad.net/~rpadovani/webbrowser-app/searchenginesmodel/+merge/250893
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~rpadovani/webbrowser-app/searchenginesmodel into lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list