[Merge] lp:~canonical-platform-qa/camera-app/use_app_for_pointing_device into lp:camera-app

Brendan Donegan brendan.donegan at canonical.com
Wed Feb 18 15:38:26 UTC 2015


Brendan Donegan has proposed merging lp:~canonical-platform-qa/camera-app/use_app_for_pointing_device into lp:camera-app.

Commit message:
Use app proxy instead of testCase for the pointing_device in MainWindow swipe_ functions

Requested reviews:
  Ubuntu Phablet Team (phablet-team)

For more details, see:
https://code.launchpad.net/~canonical-platform-qa/camera-app/use_app_for_pointing_device/+merge/250155

A couple of the functions in the MainWindow class oddly assume that the AutopilotTestCase has a pointing_device member. This is not necessarily the case but the app proxy is sure to have one, and the MainWindow class already stores the app proxy in self.app so we should really use that instead of the testCase to provide the pointing device
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~canonical-platform-qa/camera-app/use_app_for_pointing_device into lp:camera-app.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 948 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20150218/ade6d0df/attachment.diff>


More information about the Ubuntu-reviews mailing list