[Merge] lp:~psusi/ubuntu/vivid/grub-installer/fix-efi-multi-disk-installs into lp:ubuntu/grub-installer

Mathieu Trudel-Lapierre mathieu.tl at gmail.com
Tue Feb 17 02:30:16 UTC 2015


Review: Needs Fixing

There's a comment further down that explicitly mentions avoiding touching the active flag on GPT, so in that sense your changes look fine, but it seems the code that actually did ignore GPT from grub-installer itself went away, and now that is only checked in ensure-active itself -- could you move that comment and reword it so that the intent of the change is clear?

Something like "doing this because we won't set partitions active on GPT, and if $bootdisk points to a drive with no partition table things will explode in fun ways"... In your own words ;)
-- 
https://code.launchpad.net/~psusi/ubuntu/vivid/grub-installer/fix-efi-multi-disk-installs/+merge/247772
Your team Ubuntu branches is subscribed to branch lp:ubuntu/grub-installer.



More information about the Ubuntu-reviews mailing list