[Merge] lp:~abreu-alexandre/webbrowser-app/desktop-download into lp:webbrowser-app
Olivier Tilloy
olivier.tilloy at canonical.com
Wed Feb 11 09:11:13 UTC 2015
The (downloadLoader.status == Loader.Ready) condition is already strictly equivalent to (formFactor != "desktop"), so this could be rewritten:
if (downloadLoader.status == Loader.Ready) {
[existing code]
} else {
Qt.openUrlExternally(request.url)
}
The change otherwise looks good to me (but I haven’t tested it yet).
--
https://code.launchpad.net/~abreu-alexandre/webbrowser-app/desktop-download/+merge/249255
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~abreu-alexandre/webbrowser-app/desktop-download into lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list