[Merge] lp:~tiagosh/telephony-service/flag-mms into lp:telephony-service

Gustavo Pichorim Boiko gustavo.boiko at canonical.com
Wed Feb 4 20:27:55 UTC 2015


Review: Needs Fixing

195	+    QString senderId = mMessages[messageId]["senderId"].toString();
196	+    QString accountId = mMessages[messageId]["accountId"].toString();
197	+    QStringList participantIds = mMessages[messageId]["participantIds"].toStringList();

Instead of looking up for the mMessages[messageId] multiple times, maybe you could cache the result and reuse it instead.
-- 
https://code.launchpad.net/~tiagosh/telephony-service/flag-mms/+merge/243433
Your team Ubuntu Phablet Team is subscribed to branch lp:telephony-service.



More information about the Ubuntu-reviews mailing list