[Merge] lp:~mardy/location-service/providers-dir into lp:location-service
Alberto Mardegan
alberto.mardegan at canonical.com
Wed Dec 23 15:00:35 UTC 2015
I've updated the MP according to your advice; just a couple of notes:
- I didn't introduce the Receiver class and use it instead of ProviderCollection: I'll do that when the async proivider loading MP has landed.
- regarding ProviderManifest, I cannot add a constructor which takes a stream, because I need the file name; this also answer your question about that name_ variable: it's not a leftover, it's initialized in the constructor's body.
- on a side note, what's the naming convention for member variables? I see both "variable" and "variable_", are you fine with both?
- This is still not building: the src/ directory builds fine, but examples and tests still don't; I'm leaving that for after the holidays.
--
https://code.launchpad.net/~mardy/location-service/providers-dir/+merge/280724
Your team Ubuntu Phablet Team is subscribed to branch lp:location-service.
More information about the Ubuntu-reviews
mailing list