[Merge] lp:~thomas-voss/media-hub/enable-dual-landings into lp:media-hub
Łukasz Zemczak
lukasz.zemczak at canonical.com
Mon Dec 21 15:15:52 UTC 2015
Review: Needs Information packaging
Dual-landability-wise it looks ok, don't have any obvious concerns. The only concern I have is the lack of symbol files and/or anything else like a combination of shlibs+abi-compliance-checker. I also noticed that media-hub dropped its symbol files a while ago again and I was unable to find out who signed it off (maybe me?). If someone did, I wonder what was the agreement as I suppose no one sane would let this happen without some kind of a declaration like: "ok, we'll add those in x weeks".
So this is obviously my only concern. If some core-developer with more experience than me says: "ok, this is good to go without abi checks or symbols" then I guess it's fine.
--
https://code.launchpad.net/~thomas-voss/media-hub/enable-dual-landings/+merge/278270
Your team Ubuntu Phablet Team is subscribed to branch lp:media-hub.
More information about the Ubuntu-reviews
mailing list