[Merge] lp:~unity-team/qtubuntu/DPR into lp:qtubuntu

Gerry Boland gerry.boland at canonical.com
Thu Dec 17 16:05:30 UTC 2015


> Why did you remove that chunk from UbuntuSurface constructor in
> src/ubuntumirclient/window.cpp? In any case that removal is unrelated to DPR
> work.
> 
> """
>         auto geom = mWindow->geometry();
>         geom.setWidth(parameters.width);
>         geom.setHeight(parameters.height);
>         if (mWindowState == Qt::WindowFullScreen) {
>             geom.setY(0);
>         } else {
>             geom.setY(panelHeight());
>         }
> """

It was a bit related. I wanted to prevent UbuntuSurface having any knowledge of device-indepedent pixels,  I wanted it to be purely pixel based. UbuntuSurface pretty much a wrapper for a MirSurface. So that small refactor allowed me to do that, plus eliminate a small bit of duplicate code.
-- 
https://code.launchpad.net/~unity-team/qtubuntu/DPR/+merge/280820
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu.



More information about the Ubuntu-reviews mailing list