[Merge] lp:~michael-sheldon/webbrowser-app/implement-download-folder into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Tue Dec 15 15:47:00 UTC 2015


Review: Needs Fixing

src/app/webbrowser/ContentPickerDialog.qml breaks encapsulation by doing this:

    onCancelPressed: webview.focus = true

Instead, you should do:

    onCancelPressed: WebView.view.focus = true

(the 'WebView.view' attached property points to the parent webview).

By the way, is this still needed, and if so shouldn’t it be WebView.view.forceActiveFocus() ?
-- 
https://code.launchpad.net/~michael-sheldon/webbrowser-app/implement-download-folder/+merge/268815
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list