[Merge] lp:~michael-sheldon/webbrowser-app/implement-download-folder into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Tue Dec 15 10:23:29 UTC 2015


The ContentDownloadDialog.qml implementations don’t need to be an instance of Component, their top-level element can be PopupBase.

The decoupling done at revision 1209 looks good. I suppose you’re aware of it, but just as a reminder to myself: src/app/ContentPickerDialog.qml still breaks encapsulation by referring to 'webapp' and 'browser'.
-- 
https://code.launchpad.net/~michael-sheldon/webbrowser-app/implement-download-folder/+merge/268815
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list