[Merge] lp:~michael-sheldon/webbrowser-app/implement-download-folder into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Mon Dec 14 10:24:13 UTC 2015


Thanks for adding the unit tests for DownloadsModel. The current coverage is 63.3%, this is not bad but it could easily be improved. The following methods are not covered by the unit tests:
 DownloadsModel::setPath()
 DownloadsModel::setError()
 DownloadsModel::moveToDownloads()
 DownloadsModel::deleteDownload()
 DownloadsModel::pauseDownload()
 DownloadsModel::resumeDownload()
 DownloadsModel::removeExistingEntryFromDatabase()
 DownloadsModel::canFetchMore()

Also, since this is a list model, please consider monitoring the rowsAdded(), rowsRemoved(), rowsMoved() and dataChanged() signals, and verifying that they are emitted when expected, with the correct parameters.
-- 
https://code.launchpad.net/~michael-sheldon/webbrowser-app/implement-download-folder/+merge/268815
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list