[Merge] lp:~dandrader/qtubuntu/loggingCategory into lp:qtubuntu

Gerry Boland gerry.boland at canonical.com
Wed Dec 9 11:39:03 UTC 2015


Review: Needs Fixing

Q_LOGGING_CATEGORY(ubuntumirclientInput, "ubuntumirclient.input", QtWarningMsg)
did you choose the long "ubuntumirclientInput" & "ubuntumirclient" category names in fear of symbol collision?

+++ src/ubuntumirclient/input.h
+++ src/ubuntumirclient/window.h
would prefer you move the logging category declaration into the logging.h file. I think it is handy to see all categories listed in one file.

+++ src/ubuntumirclient/clipboard.cpp
you're hiding all these critical clipboard error messages by default. I think those messages are more useful if they're always printed. I'm ok hiding the warnings by default.

+++ src/ubuntumirclient/screen.cpp
+static void printEglConfig(EGLDisplay display, EGLConfig config) {
whitespace: 2 spaces after 'void'

Please edit README to give instructions on how to enable the logging output.
-- 
https://code.launchpad.net/~dandrader/qtubuntu/loggingCategory/+merge/279629
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu.



More information about the Ubuntu-reviews mailing list