[Merge] lp:~fboucault/camera-app/remove_too_low_resolutions into lp:camera-app/staging
Ugo Riboni
ugo.riboni at canonical.com
Tue Dec 8 09:33:14 UTC 2015
Review: Approve
I would think that either fittingSize >= maximumSize / 2 or adding a comment explaining "Do not show resolution option if it's lower than 50% than the maximum available resolution." would help people understand what you are doing here.
Other than that LGTM
--
https://code.launchpad.net/~fboucault/camera-app/remove_too_low_resolutions/+merge/279858
Your team Ubuntu Phablet Team is subscribed to branch lp:camera-app/staging.
More information about the Ubuntu-reviews
mailing list