[Merge] lp:~uriboni/webbrowser-app/newtabview-listviews into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Wed Dec 2 18:14:34 UTC 2015


Here is the merge request that implements the idea I described above: https://code.launchpad.net/~osomon/webbrowser-app/bookmarks-proxy-model/+merge/279277.

With a single model, only the initial instantiation of the model is costly (260ms for 100000 entries, 40ms for 10000 entries), there’s no additional overhead.

The code ended up slightly more complex than I anticipated, because I made it possible to change at runtime whether to show empty folders, and whether to prepend the homepage bookmark. That’s more code and complexity, but it’s 100% unit tested, and shields us from future design changes.
-- 
https://code.launchpad.net/~uriboni/webbrowser-app/newtabview-listviews/+merge/274986
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list