[Merge] lp:~tiagosh/telephony-service/authentication-handler into lp:telephony-service

[Gustavo Pichorim Boiko]

Review: Needs Fixing

Just one remark inline, but other than that the code looks good.

Diff comments:

> 
> === added file 'indicator/authhandler.h'
> --- indicator/authhandler.h	1970-01-01 00:00:00 +0000
> +++ indicator/authhandler.h	2015-08-19 18:07:08 +0000
> @@ -0,0 +1,53 @@
> +/*
> + * Copyright (C) 2015 Canonical, Ltd.
> + *
> + * Authors:
> + *  Tiago Salem Herrmann <tiago.herrmann at canonical.com>
> + *
> + * This file is part of telephony-service.
> + *
> + * telephony-service is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; version 3.
> + *
> + * telephony-service is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program.  If not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#ifndef AUTHHANDLER_H
> +#define AUTHHANDLER_H
> +
> +#include <QDBusInterface>
> +#include <QVariantMap>
> +#include "indicator/NotificationsInterface.h"
> +#include "accountentry.h"
> +#include "notificationmenu.h"
> +
> +class AuthHandler : public QObject
> +{
> +    Q_OBJECT
> +public:
> +    explicit AuthHandler(QObject *parent = 0);
> +
> +public Q_SLOTS:
> +    void onConnectionStatusChanged(Tp::ConnectionStatus status);
> +    void actionInvoked(uint id, const QString &actionKey);
> +    void notificationClosed(uint id, uint reason);
> +    void clear();
> +private Q_SLOTS:
> +    void setupAccounts();
> +
> +private:
> +    void processStatusChange(AccountEntry *account, Tp::ConnectionStatus status);
> +    NotificationMenu m_menuNotification;

Can you rename all the private variables to use the same format (mName instead of m_name)?

> +    org::freedesktop::Notifications m_notifications;
> +    QMap<uint, AccountEntry*> mAuthFailureRequests;
> +    QStringList mIgnoredAccounts;
> +};
> +
> +#endif // AUTHHANDLER_H


-- 
https://code.launchpad.net/~tiagosh/telephony-service/authentication-handler/+merge/262992
Your team Ubuntu Phablet Team is subscribed to branch lp:telephony-service.