[Merge] lp:~osomon/webbrowser-app/oxide-context-menu into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Fri Aug 21 17:24:24 UTC 2015


Olivier Tilloy has proposed merging lp:~osomon/webbrowser-app/oxide-context-menu into lp:webbrowser-app.

Commit message:
Use the contextMenu API new in oxide 1.8.
Update the visuals for the context menu in narrow and wide form factors.
Add text editing commands to the context menu.
Add unit and autopilot tests for the context menu features.
This bumps the runtime dependency of webapp-container and qtdeclarative5-ubuntu-web-plugin on liboxideqt-qmlplugin to 1.8.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1264493 in webbrowser-app (Ubuntu): "No Paste option in web page entries"
  https://bugs.launchpad.net/ubuntu/+source/webbrowser-app/+bug/1264493
  Bug #1326070 in Oxide: "Add support for context menus"
  https://bugs.launchpad.net/oxide/+bug/1326070
  Bug #1438046 in webbrowser-app (Ubuntu): "Can't download protected images"
  https://bugs.launchpad.net/ubuntu/+source/webbrowser-app/+bug/1438046
  Bug #1450430 in webbrowser-app (Ubuntu): "Text selection box drawn in wrong place"
  https://bugs.launchpad.net/ubuntu/+source/webbrowser-app/+bug/1450430
  Bug #1471181 in Oxide: "Test that WebContextMenu position property is in the correct coordinate space"
  https://bugs.launchpad.net/oxide/+bug/1471181
  Bug #1477309 in webbrowser-app (Ubuntu): "right click menu looks disabled, change the styling"
  https://bugs.launchpad.net/ubuntu/+source/webbrowser-app/+bug/1477309
  Bug #1477310 in webbrowser-app (Ubuntu): "[convergence] Save image option not appearing when right clicking on image"
  https://bugs.launchpad.net/ubuntu/+source/webbrowser-app/+bug/1477310
  Bug #1477315 in webbrowser-app (Ubuntu): "[convergence] Popup menu displayed in wrong spot on desktop when invoked over links (not close to the link)"
  https://bugs.launchpad.net/ubuntu/+source/webbrowser-app/+bug/1477315
  Bug #1487090 in Oxide: "Download initiated from context menu’s saveLink/saveMedia doesn’t expose a mime type"
  https://bugs.launchpad.net/oxide/+bug/1487090

For more details, see:
https://code.launchpad.net/~osomon/webbrowser-app/oxide-context-menu/+merge/268786
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~osomon/webbrowser-app/oxide-context-menu into lp:webbrowser-app.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 68248 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20150821/84d3266c/attachment-0001.diff>


More information about the Ubuntu-reviews mailing list