[Merge] lp:~artmello/webbrowser-app/webbrowser-app-fix_1484562 into lp:webbrowser-app
Olivier Tilloy
olivier.tilloy at canonical.com
Mon Aug 17 14:49:22 UTC 2015
Review: Needs Fixing
In the two new test functions, checking that the 'count' property of a spy is 0 right after calling clear() on that spy is useless. This is guaranteed to be true, by definition.
In onDeletePressed, if the left panel has active focus and the current index is 0 ("All History"), you could call historyModel.clearAll() instead of iterating through all the entries to delete them one by one.
Similarly, it might be interesting to add a 'clearByDate()' method to the history model to allow deleting all the entries for one given date, instead of iterating. This would be faster and cleaner.
--
https://code.launchpad.net/~artmello/webbrowser-app/webbrowser-app-fix_1484562/+merge/268165
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list