[Merge] lp:~uriboni/webbrowser-app/no-find-in-page-in-new-tab into lp:webbrowser-app

[Olivier Tilloy]

This looks good to me. I have one minor comment, see inline.



Diff comments:

> === modified file 'src/app/webbrowser/Browser.qml'
> --- src/app/webbrowser/Browser.qml	2015-08-11 10:37:56 +0000
> +++ src/app/webbrowser/Browser.qml	2015-08-12 15:21:58 +0000
> @@ -1502,8 +1502,10 @@
>              modifiers: Qt.ControlModifier
>              key: Qt.Key_F
>              onTriggered: {
> -                chrome.findInPageMode = true
> -                chrome.focus = true
> +                if (!newTabViewLoader.active) {
> +                    chrome.findInPageMode = true
> +                    chrome.focus = true
> +                }

Why not set the 'enabled' property of the KeyboardShortcut to '!newTabViewLoader.active' instead?

>              }
>          }
>      }


-- 
https://code.launchpad.net/~uriboni/webbrowser-app/no-find-in-page-in-new-tab/+merge/267829
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~uriboni/webbrowser-app/no-find-in-page-in-new-tab into lp:webbrowser-app.