[Merge] lp:~artmello/webbrowser-app/webbrowser-app-history_view_convergence into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Tue Aug 11 15:40:15 UTC 2015


Review: Needs Fixing

In tst_HistoryViewWide.qml, the initial population of the history model doesn’t need to happen before each test run (init() is run before each test function), it could be done in initTestCase (see doc.qt.io/qt-5/qml-qttest-testcase.html#initTestCase-method).

And isn’t there a cleaner way than a wait() to ensure that the model is actually populated? Can’t we watch a signal, or tryCompare on the model’s count?
-- 
https://code.launchpad.net/~artmello/webbrowser-app/webbrowser-app-history_view_convergence/+merge/263052
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list