[Merge] lp:~canonical-platform-qa/camera-app/fix_base_class into lp:camera-app

Leo Arias leo.arias at canonical.com
Tue Apr 28 15:48:26 UTC 2015


Leo Arias has proposed merging lp:~canonical-platform-qa/camera-app/fix_base_class into lp:camera-app.

Commit message:
Use the base class from the toolkit in autopilot tests.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)

For more details, see:
https://code.launchpad.net/~canonical-platform-qa/camera-app/fix_base_class/+merge/257658

Autopilot is currently designed to have a single proxy object base, so we started finding some problems when we integrated tests from multiple projects for the sanity suite. We are working on making autopilot smarter, but in order to be able to change the design without breaking any tests we need this change.
And in this case, it makes sense to use the proxy object from the toolkit, because the one defined for this project was just duplicating the code.
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~canonical-platform-qa/camera-app/fix_base_class into lp:camera-app.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 4434 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20150428/84f64efd/attachment.diff>


More information about the Ubuntu-reviews mailing list