[Merge] lp:~mandel/location-service/remove-cotroller into lp:location-service

Thomas Voß thomas.voss at canonical.com
Tue Apr 28 06:12:08 UTC 2015


Review: Needs Fixing

Slightly confused by this change. Removing the controller is probably fine, but folding the functionality into location::Provider is a bit difficult to me. Removing the controller would offer the opportunity to make location::Provider an abstract base class with the obvious benefits. With that, I would propose to introduce a class StateTrackingProvider : public location::Provider that takes a location::Provider instance and makes sure that start_*_updates are only ever called once.
-- 
https://code.launchpad.net/~mandel/location-service/remove-cotroller/+merge/257575
Your team Ubuntu Phablet Team is subscribed to branch lp:location-service.



More information about the Ubuntu-reviews mailing list