[Merge] lp:~mandel/location-service/handle-exceptions into lp:location-service

Manuel de la Peña manuel.delapena at canonical.com
Thu Apr 16 09:16:38 UTC 2015


This was talked about on irc:

The while loop does not expose a problem in multithreaded situations because the io_service class already provides such a flag. Stop, as per documentation, will stop the main loop, if a io_service has been stopped, as the documentation states, the run method returns immediately meaning that we hit the break statement and get out of the loop.

If a reset call is performed, there are no issues because reset implies the preparation of a call to run meaning that getting in the loop an executing run won't be an issue. 

The comment about "execute(std::shared_ptr<core::dbus::Bus> bus) {...} " is perfectly valid and will be implemented that way.
-- 
https://code.launchpad.net/~mandel/location-service/handle-exceptions/+merge/256157
Your team Ubuntu Phablet Team is subscribed to branch lp:location-service.



More information about the Ubuntu-reviews mailing list