[Merge] lp:~artmello/gallery-app/gallery-app-fix_autopilot_tests into lp:gallery-app

Federico Gimenez fgimenez at canonical.com
Wed Apr 15 16:05:23 UTC 2015


Review: Approve

Looks good in general and the tests are passing on krillin, someone else should check on mako. 

You should double check the wait_select_single calls are used for elements that are not previously present in the ui (for those that are you should use select_single) and that the visible kwarg is used when needed (elements that appear eventually).

There are some flake8 minor issues (you can check them with 'python3 -m flake8.run .'), not a blocker.

Cheers!
-- 
https://code.launchpad.net/~artmello/gallery-app/gallery-app-fix_autopilot_tests/+merge/256159
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~artmello/gallery-app/gallery-app-fix_autopilot_tests into lp:gallery-app.



More information about the Ubuntu-reviews mailing list