[Merge] lp:~artmello/webbrowser-app/webbrowser-app-format_top_sites into lp:webbrowser-app
Olivier Tilloy
olivier.tilloy at canonical.com
Tue Apr 14 20:42:24 UTC 2015
Review: Needs Fixing
- The fix to src/app/webbrowser/history-model.cpp (insertStatement) should go in the prerequisite branch (lp:~artmello/webbrowser-app/webbrowser-app-remove_top_sites), not this one.
- I’m not sure I understand the new unit test (shouldUpdateRowCountAndNotifyAfterAnEntryIsRemoved): when removing the first row, I would expect a rowsRemoved signal to be emitted for the first row, and a rowsInserted signal to be emitted for the new row that comes into view. Is this not how the limit proxy model works?
--
https://code.launchpad.net/~artmello/webbrowser-app/webbrowser-app-format_top_sites/+merge/255298
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list