[Merge] lp:~phablet-team/network-manager/lp1418077 into lp:~network-manager/network-manager/ubuntu
Tony Espy
espy at canonical.com
Mon Apr 6 17:57:31 UTC 2015
Tony Espy has proposed merging lp:~phablet-team/network-manager/lp1418077 into lp:~network-manager/network-manager/ubuntu.
Requested reviews:
Network-manager (network-manager)
Related bugs:
Bug #1418077 in network-manager (Ubuntu): "After connection drops, mobile-data takes ~5m to re-connect"
https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/1418077
For more details, see:
https://code.launchpad.net/~phablet-team/network-manager/lp1418077/+merge/255285
This merge proposal includes three changes:
1. A general cleanup of the NM ofono code ( src/devices/wwan/nm-modem-ofono.c ), getting rid of unused and/or code that was commented out.
2. A bug fix for lp: #1418077 - NM takes ~5m to reconnect after GPRS detaches.
3. A second cleanup of the NM ofono code which also fixes indentation and improper if/else formatting.
--
Your team Network-manager is requested to review the proposed merge of lp:~phablet-team/network-manager/lp1418077 into lp:~network-manager/network-manager/ubuntu.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 24804 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20150406/64acf0eb/attachment-0001.diff>
More information about the Ubuntu-reviews
mailing list