[Merge] lp:~tiagosh/messaging-app/information-messageType into lp:messaging-app

Gustavo Pichorim Boiko gustavo.boiko at canonical.com
Tue Sep 30 21:06:05 UTC 2014


Review: Needs Fixing

130	+                var fakeString = i18n.tr("You switched to %1")
139	+                                                             "You switched to %1")

This approach is not good, because if at any time we decide to change the displayed message, the existing events will lose the translation.

Maybe we can use a dynamic message and save a well known eventId or something like that to indicate the event is a SIM switch?
-- 
https://code.launchpad.net/~tiagosh/messaging-app/information-messageType/+merge/235860
Your team Ubuntu Phablet Team is subscribed to branch lp:messaging-app.



More information about the Ubuntu-reviews mailing list