[Merge] lp:~mir-team/platform-api/support-state-changing into lp:platform-api

Daniel d'Andrada daniel.dandrada at canonical.com
Tue Sep 30 19:49:37 UTC 2014


Review: Needs Fixing

It's adding duplicate entries to debian/changelog.

---------------

Gotta update debian/libubuntu-application-api2.symbols. Instead of specifying a version put the placeholder "0replaceme" instead. CI will take care of replacing it with the version number being released.

----------------

in CMakeLists.txt:

"""
-set(UBUNTU_PLATFORM_API_VERSION_MINOR 3)
+set(UBUNTU_PLATFORM_API_VERSION_MINOR 5)
"""

Why jumping from 3 to 5 (skipping 4)?
-- 
https://code.launchpad.net/~mir-team/platform-api/support-state-changing/+merge/235545
Your team Ubuntu Phablet Team is subscribed to branch lp:platform-api.



More information about the Ubuntu-reviews mailing list