[Merge] lp:~mir-team/qtubuntu/support-state-changing into lp:qtubuntu
Daniel d'Andrada
daniel.dandrada at canonical.com
Tue Sep 30 19:25:12 UTC 2014
Review: Needs Fixing
Code looks good, but that TODO comment is confusing. Please remove it.
That "Active|Minimized" in the DLOG message simply means that setWindowState() was called either with Qt::WindowActive or with Qt::WindowMinimized. Nothing more than that. It's just because the author didn't bother writing a separate DLOG message for each one of those two cases.
setWindowState() gets an enumeration, not a bitfield of flags.
--
https://code.launchpad.net/~mir-team/qtubuntu/support-state-changing/+merge/235546
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu.
More information about the Ubuntu-reviews
mailing list