[Merge] lp:~sergiusens/nuntium/select_that into lp:nuntium

Antti Kaijanmäki antti.kaijanmaki at canonical.com
Tue Sep 30 14:19:13 UTC 2014


Review: Needs Fixing

My go-fu is bad, but I don't see the service notifying when the PreferredContext property changes.

It's also problematic that the property sometimes is available and sometimes it's not. I can work around this in the bindings, but I need two things:

1) instead of adding/removing the property, have a "not set" value (empty string would do just fine) and have the interface report PropertyChanged signal each time the property is modified
2) or add a straight signal PreferredContextChangede when you add or remove the property.


Current implementation makes it really difficult (or almost impossible) to write bindings on Qt.


-- 
https://code.launchpad.net/~sergiusens/nuntium/select_that/+merge/236427
Your team Ubuntu Phablet Team is subscribed to branch lp:nuntium.



More information about the Ubuntu-reviews mailing list