[Merge] lp:~renatofilho/mediaplayer-app/translators-comments into lp:mediaplayer-app

Tue Sep 30 05:29:35 UTC 2014

Review: Needs Fixing

Thanks. I've added a couple of inline comments.

Also, could the po/pt_BR.po file be removed from the diff? Translations should be done in Launchpad, and they will overwrite the .po file anyway.

Diff comments:

> === modified file 'po/mediaplayer-app.pot'
> --- po/mediaplayer-app.pot	2014-04-17 20:54:33 +0000
> +++ po/mediaplayer-app.pot	2014-09-29 21:02:26 +0000
> @@ -8,7 +8,7 @@
>  msgstr ""
>  "Project-Id-Version: PACKAGE VERSION\n"
>  "Report-Msgid-Bugs-To: \n"
> -"POT-Creation-Date: 2014-03-27 18:44-0400\n"
> +"POT-Creation-Date: 2014-09-29 18:01-0300\n"
>  "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
>  "Last-Translator: FULL NAME <EMAIL at ADDRESS>\n"
>  "Language-Team: LANGUAGE <LL at li.org>\n"
> @@ -17,23 +17,25 @@
>  "Content-Type: text/plain; charset=CHARSET\n"
>  "Content-Transfer-Encoding: 8bit\n"
>  
> -#: src/qml/player/TimeLine.qml:135
> +#. TRANSLATORS: this refers to a duration/remaining time of the video, of which you can change the order.
> +#. %1 refers to hours, %2 refers to minutes and %3 refers to seconds.
> +#: src/qml/player/TimeLine.qml:138
>  #, qt-format
>  msgid "%1:%2:%3"
>  msgstr ""
>  
> -#: src/qml/player/TimeLine.qml:104
> +#: src/qml/player/TimeLine.qml:105
>  #, qt-format
>  msgid "- %1"

This string needs a translator comment.

>  msgstr ""
>  
> -#: src/qml/player/TimeLine.qml:131 src/qml/player/TimeLine.qml:132
> -#: src/qml/player/TimeLine.qml:133
> +#: src/qml/player/TimeLine.qml:132 src/qml/player/TimeLine.qml:133
> +#: src/qml/player/TimeLine.qml:134
>  #, qt-format
>  msgid "0%1"

This string needs translator comment

>  msgstr ""
>  
> -#: src/qml/player/TimeLine.qml:71
> +#: src/qml/player/TimeLine.qml:72
>  msgid "0:00:00"
>  msgstr ""
>  
> @@ -68,6 +70,7 @@
>  msgid "Share"
>  msgstr ""
>  
> -#: src/qml/player/TimeLine.qml:68
> +#. TRANSLATORS: this refers to an unknown duration.
> +#: src/qml/player/TimeLine.qml:69
>  msgid "unknown"
>  msgstr ""
> 
> === modified file 'po/pt_BR.po'
> --- po/pt_BR.po	2014-09-26 06:48:28 +0000
> +++ po/pt_BR.po	2014-09-29 21:02:26 +0000
> @@ -6,70 +6,71 @@
>  msgid ""
>  msgstr ""
>  "Project-Id-Version: mediaplayer-app\n"
> -"Report-Msgid-Bugs-To: FULL NAME <EMAIL at ADDRESS>\n"
> -"POT-Creation-Date: 2014-03-27 18:44-0400\n"
> +"Report-Msgid-Bugs-To: \n"
> +"POT-Creation-Date: 2013-05-23 11:11-0300\n"
>  "PO-Revision-Date: 2014-02-05 12:22+0000\n"
>  "Last-Translator: Douglas Massolari <douglasmassolari at hotmail.com>\n"
>  "Language-Team: Brazilian Portuguese <pt_BR at li.org>\n"
> +"Language: pt_BR\n"
>  "MIME-Version: 1.0\n"
>  "Content-Type: text/plain; charset=UTF-8\n"
>  "Content-Transfer-Encoding: 8bit\n"
>  "X-Launchpad-Export-Date: 2014-09-26 06:48+0000\n"
>  "X-Generator: Launchpad (build 17196)\n"
>  
> -#: src/qml/player/TimeLine.qml:135
> +#. TRANSLATORS: this refers to a duration/remaining time of the video, of which you can change the order.
> +#. %1 refers to hours, %2 refers to minutes and %3 refers to seconds.
> +#: src/qml/player/TimeLine.qml:136
>  #, qt-format
>  msgid "%1:%2:%3"
>  msgstr "%1:%2:%3"
>  
> -#: src/qml/player/TimeLine.qml:104
> +#: src/qml/player/TimeLine.qml:103
>  #, qt-format
>  msgid "- %1"
>  msgstr "- %1"
>  
> -#: src/qml/player/TimeLine.qml:131 src/qml/player/TimeLine.qml:132
> -#: src/qml/player/TimeLine.qml:133
> +#: src/qml/player/TimeLine.qml:130 src/qml/player/TimeLine.qml:131
> +#: src/qml/player/TimeLine.qml:132
>  #, qt-format
>  msgid "0%1"
>  msgstr "0%1"
>  
> -#: src/qml/player/TimeLine.qml:71
> +#: src/qml/player/TimeLine.qml:70
>  msgid "0:00:00"
>  msgstr "0:00:00"
>  
> -#: src/qml/player.qml:67
> -msgid "Error"
> -msgstr "Erro"
> -
> -#: data/mediaplayer-app.desktop.in:3 data/mediaplayer-app.desktop.in:4
> -#: data/mediaplayer-app.desktop.in:5
> -msgid "Media Player"
> -msgstr "Reprodutor de mídia"
> -
> -#: src/qml/player.qml:68
> -msgid ""
> -"No video selected to play. Connect your phone to your computer to transfer "
> -"videos to the phone. Then select video from Videos lens."
> -msgstr ""
> -"Nenhum vídeo selecionado. Conecte o telefone ao computador para transferir "
> -"vídeos para o telefone. Em seguida selecione o vídeo na lente de Vídeo."
> -
> -#: src/qml/player.qml:189
> +#: src/qml/player.qml:159
>  msgid "Pause or Resume Playhead"
>  msgstr "Pausar ou continuar reprodução"
>  
> -#: src/qml/player.qml:188
> +#: src/qml/player.qml:158
>  msgid "Play / Pause"
>  msgstr "Reproduzir / pausar"
>  
> -#: src/qml/player.qml:194
> +#: src/qml/player.qml:163
>  msgid "Post;Upload;Attach"
>  msgstr "Postar;Enviar;Anexar"
>  
> -#: src/qml/player.qml:193
> +#: src/qml/player.qml:162
>  msgid "Share"
>  msgstr "Compartilhar"
>  
> -#: src/qml/player/TimeLine.qml:68
> +#. TRANSLATORS: this refers to an unknown duration.
> +#: src/qml/player/TimeLine.qml:67
>  msgid "unknown"
>  msgstr "desconhecido"
> +
> +#~ msgid "Error"
> +#~ msgstr "Erro"
> +
> +#~ msgid "Media Player"
> +#~ msgstr "Reprodutor de mídia"
> +
> +#~ msgid ""
> +#~ "No video selected to play. Connect your phone to your computer to "
> +#~ "transfer videos to the phone. Then select video from Videos lens."
> +#~ msgstr ""
> +#~ "Nenhum vídeo selecionado. Conecte o telefone ao computador para "
> +#~ "transferir vídeos para o telefone. Em seguida selecione o vídeo na lente "
> +#~ "de Vídeo."
> 
> === modified file 'src/qml/player/TimeLine.qml'
> --- src/qml/player/TimeLine.qml	2013-12-20 20:04:41 +0000
> +++ src/qml/player/TimeLine.qml	2014-09-29 21:02:26 +0000
> @@ -65,6 +65,7 @@
>                  if (_slider.maximumValue > 0) {
>                      _timeLine.remainingTime = formatProgress(_slider.maximumValue - value)
>                  } else {
> +                    // TRANSLATORS: this refers to an unknown duration.
>                      _timeLine.remainingTime = i18n.tr("unknown")
>                  }
>              } else {
> @@ -132,6 +133,8 @@
>          if (min < 10) min = i18n.tr("0%1").arg(min)
>          if (hour < 10) hour = i18n.tr("0%1").arg(hour)
>  
> +        // TRANSLATORS: this refers to a duration/remaining time of the video, of which you can change the order.
> +        // %1 refers to hours, %2 refers to minutes and %3 refers to seconds.
>          return  i18n.tr("%1:%2:%3").arg(hour).arg(min).arg(secs)
>      }
>  }
> 

-- 
https://code.launchpad.net/~renatofilho/mediaplayer-app/translators-comments/+merge/165260
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~renatofilho/mediaplayer-app/translators-comments into lp:mediaplayer-app.