[Merge] lp:~gnuoy/nova/bug1314677 into lp:~ubuntu-server-dev/nova/icehouse

James Page james.page at ubuntu.com
Mon Sep 29 13:23:43 UTC 2014


Review: Needs Fixing

Hi Liam

Thanks for the MP; a few comments

1) has this patch been cherry picked upstream for the stable/icehouse branch? If no please submit a review following https://wiki.openstack.org/wiki/StableBranch

2) I'd like to see either a) a full annotate git patch as would be committed upstream or b) appropriate patch headers (see http://dep.debian.net/deps/dep5/) so we can track the heritage of this patch.

Also its good practice to leave the changelog entry as UNRELEASED (instead of trusty) so dch keeps appending to the existing UNRELEASED version.

Cheers

James
-- 
https://code.launchpad.net/~gnuoy/nova/bug1314677/+merge/236321
Your team Ubuntu Server Developers is subscribed to branch lp:~ubuntu-server-dev/nova/icehouse.



More information about the Ubuntu-reviews mailing list