[Merge] lp:~ogra/phablet-tools/phablet-test-run-fix-broken-shell into lp:phablet-tools
Oliver Grawert
ogra at ubuntu.com
Mon Sep 29 07:53:43 UTC 2014
i thought the test scripts do the package setup in advance anyway so that you do not need the -p option (which means you wont need the -r option either) at least i have never seen -p used for phablet-test-run in the logs.
in a normal lab test run -p should not be needed.
more important for smoke testing is the removal of "/bin/sh -c" from the commands, which in the new world does the right thing and drops the environment to the one of /bin/sh ... which in turn means it also drops all knowledge about dbus and upstart sessions. without thid no app test will run at all.
--
https://code.launchpad.net/~ogra/phablet-tools/phablet-test-run-fix-broken-shell/+merge/236252
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~ogra/phablet-tools/phablet-test-run-fix-broken-shell into lp:phablet-tools.
More information about the Ubuntu-reviews
mailing list