[Merge] lp:~sergiusens/goget-ubuntu-touch/minor_improv into lp:goget-ubuntu-touch

Sergio Schvezov sergio.schvezov at canonical.com
Thu Sep 25 13:51:46 UTC 2014


Sergio Schvezov has proposed merging lp:~sergiusens/goget-ubuntu-touch/minor_improv into lp:goget-ubuntu-touch.

Commit message:
ubuntu-device-flash: minor improvements to user experience and code polish

Requested reviews:
  Ubuntu Phablet Team (phablet-team)

For more details, see:
https://code.launchpad.net/~sergiusens/goget-ubuntu-touch/minor_improv/+merge/235965

Things like this when flashing from recovery without specifying device:
./ubuntu-device-flash --channel ubuntu-touch/ubuntu-rtm/14.09-proposed 
2014/09/25 10:39:46 Expecting the device to expose an adb interface...
2014/09/25 10:39:46 Cannot determine the device name: exit status 255

or instead of the confusing cache error:
./ubuntu-device-flash --channel ubuntu-touch/ubuntu-rtm/14.09-proposed --device krillin
2014/09/25 10:38:05 Device is |krillin|
2014/09/25 10:38:07 Flashing version 64 from ubuntu-touch/ubuntu-rtm/14.09-proposed channel and server https://system-image.ubuntu.com to device krillin
2014/09/25 10:38:07 Target device cannot be reached over adb

and when bootstrapping I added a missing error check to see if recovery was indeed entered to

the rest is code polish, it was getting hard to read.
-- 
https://code.launchpad.net/~sergiusens/goget-ubuntu-touch/minor_improv/+merge/235965
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~sergiusens/goget-ubuntu-touch/minor_improv into lp:goget-ubuntu-touch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 3414 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140925/56d05fe1/attachment.diff>


More information about the Ubuntu-reviews mailing list