[Merge] lp:~albaguirre/media-hub/fix-1371454 into lp:media-hub

Alberto Aguirre alberto.aguirre at canonical.com
Thu Sep 25 03:13:26 UTC 2014


Alberto Aguirre has proposed merging lp:~albaguirre/media-hub/fix-1371454 into lp:media-hub.

Commit message:
Fix self deadlock when clients disconnect from media::Player

When receiving a media::PlayerImplementation on_client_disconnected signal, avoid calling
remove_player_for_key within the same context as the player object may be deleted (which owns
the signal object whose destructor waits until all slots are dispatched).

Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1371454 in Media Hub: "unity8.indicators.tests.test_indicators.IndicatorExistsTestCase.test_indicator_exists hangs on mako #245 #246"
  https://bugs.launchpad.net/media-hub/+bug/1371454

For more details, see:
https://code.launchpad.net/~albaguirre/media-hub/fix-1371454/+merge/235893

Fix self deadlock when clients disconnect from media::Player

When receiving a media::PlayerImplementation on_client_disconnected signal, avoid calling
remove_player_for_key within the same context as the player object may be deleted (which owns
the signal object whose destructor waits until all slots are dispatched).
-- 
https://code.launchpad.net/~albaguirre/media-hub/fix-1371454/+merge/235893
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~albaguirre/media-hub/fix-1371454 into lp:media-hub.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 777 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140925/ea5d7de6/attachment.diff>


More information about the Ubuntu-reviews mailing list