[Merge] lp:~artmello/gallery-app/gallery-app-support_photo_url into lp:gallery-app
Bill Filler
bill.filler at canonical.com
Thu Sep 25 01:34:11 UTC 2014
Review: Needs Fixing
It's registered properly but it has issues:
1) Launch app, go to events page
- call url-dispatcher photo://file1.jpg
- the photo is opened correctly
- tap the photo to display the header
- press the back button in the header to go back to Events view
- call url-dispatcher photo://file1.jpg again
- the photo is never shown
Photos are never shown if they were previously requested by url-dispatcher.
2) Launch app, go to events page
- call url-dispatcher photo://file1.jpg
- the photo is opened correctly
- call url-dispatcher photo://file2.jpg
- the photo is opened correctly
- tap on the photo to display header
- press the back button
- You get a blank page, still showing the Gallery header with the back button
- press the back button again and it correctly shows the Events view
Seems like each time you open a photo via the url-dispatcher you are putting a new page on the stack and you have to pop all of them by pressing the back button each time to get back to the event view. This is not correct. If you repeat the same thing above 5 times you have to press back button 5 times to get back to Events view.
3) Similar problem
- open a photo from Events view or Photo view
- call url-dispatcher photo://file1.jpg
- tap photo to reveal header
- press back button
- get a blank page with Gallery header
--
https://code.launchpad.net/~artmello/gallery-app/gallery-app-support_photo_url/+merge/235656
Your team Ubuntu Phablet Team is subscribed to branch lp:gallery-app.
More information about the Ubuntu-reviews
mailing list