[Merge] lp:~pwlars/phablet-tools/network-no-sudo into lp:phablet-tools

Paul Larson paul.larson at canonical.com
Tue Sep 23 18:11:22 UTC 2014


Paul Larson has proposed merging lp:~pwlars/phablet-tools/network-no-sudo into lp:phablet-tools.

Commit message:
Don't use sudo in phablet-network unless it's really needed

Requested reviews:
  Ubuntu Phablet Team (phablet-team)

For more details, see:
https://code.launchpad.net/~pwlars/phablet-tools/network-no-sudo/+merge/235689

We're trying to eliminate the sources of sudo needed in the ci testing process. In this case, even if you specify a network file for phablet-network to use and you have full permissions on it, phablet-network uses sudo to grep for the lines it needs from it unnecessarily. This fixes that so that it should only use sudo if the file is unreadable by the current user.
-- 
https://code.launchpad.net/~pwlars/phablet-tools/network-no-sudo/+merge/235689
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~pwlars/phablet-tools/network-no-sudo into lp:phablet-tools.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 645 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140923/e30b79b8/attachment.diff>


More information about the Ubuntu-reviews mailing list