[Merge] lp:~phablet-team/ofono/rtm-bug-fix-update-1 into lp:ofono

Tony Espy espy at canonical.com
Sat Sep 20 19:18:30 UTC 2014


Tony Espy has proposed merging lp:~phablet-team/ofono/rtm-bug-fix-update-1 into lp:ofono.

Commit message:
* include, plugins/mtk.c, src/modem.c,sim.c: Fix PUK crash (LP: #1365481)
  If the SIM gets locked in particular sequence, ofono will crash
  while trying to free the list of SIM SPN watch events ( which
  have already been freed ).  MTK fix is a bit more involved than
  the stanard RIL logic.
* plugins/mtk.c,ril.c: Show emergency numbers in flight-mode (LP: #1366188)
  Modify plugin logic to create the SimManager interface even if
  no SIM is present.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1365481 in ofono (Ubuntu): "Both modem interfaces go momentarily down if one SIM goes PUK locked"
  https://bugs.launchpad.net/ubuntu/+source/ofono/+bug/1365481
  Bug #1366188 in ofono (Ubuntu): "Boot with no SIM and FlightMode enabled, no EmergencyNumbers are available"
  https://bugs.launchpad.net/ubuntu/+source/ofono/+bug/1366188

For more details, see:
https://code.launchpad.net/~phablet-team/ofono/rtm-bug-fix-update-1/+merge/235388

RTM bug fix update for ofono.

Fixes one SIM related crash, and one issue which prevents emergency calls if no SIM is installed.

-- 
The attached diff has been truncated due to its size.
https://code.launchpad.net/~phablet-team/ofono/rtm-bug-fix-update-1/+merge/235388
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~phablet-team/ofono/rtm-bug-fix-update-1 into lp:ofono.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 524288 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140920/92829224/attachment-0001.diff>


More information about the Ubuntu-reviews mailing list