[Merge] lp:~michael-sheldon/webbrowser-app/ssl-status into lp:webbrowser-app

Michael Sheldon michael.sheldon at canonical.com
Fri Sep 19 16:23:26 UTC 2014


Michael Sheldon has proposed merging lp:~michael-sheldon/webbrowser-app/ssl-status into lp:webbrowser-app.

Commit message:
* Display padlock when viewing pages over HTTPS.
* Provide certificate details when padlock is clicked.
* Display error pages when invalid SSL certificates are presented and allow users to override these warnings. 
* Display warning symbol when insecure content is loaded over HTTPS (currently incorrect icon, should be updated when dialog-warning-symbol lands in ubuntu-theme).

Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1214034 in webbrowser-app: "Implement API for querying SSL status and certificate information and signalling SSL errors to the embedder"
  https://bugs.launchpad.net/webbrowser-app/+bug/1214034
  Bug #1351182 in webbrowser-app: "Secure connection should display a symbolic padlock icon in the address bar"
  https://bugs.launchpad.net/webbrowser-app/+bug/1351182

For more details, see:
https://code.launchpad.net/~michael-sheldon/webbrowser-app/ssl-status/+merge/235309

* Display padlock when viewing pages over HTTPS.
* Provide certificate details when padlock is clicked.
* Display error pages when invalid SSL certificates are presented and allow users to override these warnings. 
* Display warning symbol when insecure content is loaded over HTTPS (currently incorrect icon, should be updated when dialog-warning-symbol lands in ubuntu-theme).
-- 
https://code.launchpad.net/~michael-sheldon/webbrowser-app/ssl-status/+merge/235309
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~michael-sheldon/webbrowser-app/ssl-status into lp:webbrowser-app.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 28195 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140919/a45a75d7/attachment-0001.diff>


More information about the Ubuntu-reviews mailing list